Post Pay Counter Pro – Flushing Rewrite Rules

Hi Serkan,
I’m not sure (it could be a problem with my plugin), but since the issue started showing up after an update of the other plugin, could you please ask their support team what could have changed that affected this feature?

Have a nice day,
Stefano

Hi Stefano,

rtCamp has given me a response regarding this issue. Here it is…

Hi Serkan,

This is Ritesh from rtMedia team. I have checked Post Pay Counter Pro plugin’s code for rewrite rules in your site. First of all, it isn’t a proper way to add rewrite rules in WordPress.

//In post-pay-counter-pro.php file
add_action( 'init', array( 'PPCP_paypal_functions', 'ipn_add_rewrite_rule' ) );

//In classes/PPCP_paypal_functions.php file
static function ipn_add_rewrite_rule() {
    global $wp_rewrite;

    if( ! is_object( $wp_rewrite ) ) $wp_rewrite = new WP_Rewrite();

    //Add IPN listener rule if not there already
    $rules = $wp_rewrite->wp_rewrite_rules();
    if( ! isset( $rules['ppcp/paypal$'] ) ) {
        add_rewrite_rule( 'ppcp/paypal$', 'index.php?ppcp=paypal', 'top' );
        $wp_rewrite->flush_rules();
    }
}

If you are familiar with WordPress ecosystem, look at the above code. This ipn_add_rewrite_rule function is bind to WordPress’ init hook with default priority which will be called on every page request and that function contains this line $wp_rewrite->flush_rules() which flushes the rewrite rules. If you comment that line, it will work all fine without any issue. This can only be fixed in Post Pay Counter Pro plugin.

In rtMedia, we too flush the rewrite rules but it’s only happen on new version update. I hope you understand my point here.

Thanks.

If I comment out the line $wp_rewrite->flush_rules();, do you think there will be any problem with Post Pay Counter not working correctly?

Thanks
Serkan

Hi Stefano,

Ok, I can confirm that commenting out those two lines $wp_rewrite->flush_rules(); lines did in fact resolve the issue. After activating Post Pay Counter and Post Pay Counter PRO, I went to the Rewrite Rules Inspector and saw that the rewrite rule for ppcp/paypal$ was red (because activating the plugin didn’t flush it anymore. So I flushed the rewrite rules and all is working peacefully now. I am not sure exactly which function it was (maybe both), but here are the two functions where I commented the lines out. Both located in post-pay-counter-pro/classes/ppcp_paypal_class.php…

/**
     * Adds plugin's IPN rewrite rule (ppcp/paypal).
     *
     * @access  public
     * @since   1.3
     */
	
	 static function ipn_add_rewrite_rule() {
        global $wp_rewrite;
		
        if( ! is_object( $wp_rewrite ) ) $wp_rewrite = new WP_Rewrite();
        
        //Add IPN listener rule if not there already
        $rules = $wp_rewrite->wp_rewrite_rules();
        if( ! isset( $rules['ppcp/paypal$'] ) ) {
            add_rewrite_rule( 'ppcp/paypal$', 'index.php?ppcp=paypal', 'top' );
            //$wp_rewrite->flush_rules();
        }
    }
    
    /**
     * Deletes plugin's IPN rewrite rule (ppcp/paypal).
     *
     * @access  public
     * @since   1.3.2
     */
	
	 static function ipn_delete_rewrite_rule() {
        global $wp_rewrite;
		
        if( ! is_object( $wp_rewrite ) ) $wp_rewrite = new WP_Rewrite();
        
        //Delete IPN listener rule if there
        $rules = $wp_rewrite->wp_rewrite_rules();
        if( isset( $rules['ppcp/paypal$'] ) ) {
            unset( $rules['ppcp/paypal$'] );
            //$wp_rewrite->flush_rules();
        }
        
    }

Not sure what’s going on in regards to when the flush_rules() is supposed to run but it’s definitely causing the conflict with rtMedia. Maybe something to do with priority??

Anyway, let me know if theres anything else you want to know and also if you plan on changing this for future releases so I know what to do when I update Post Pay Counter PRO.

Thanks
Serkan